Skip to content

TD-5290- Issue on 'Course set up' screen when selected All course content first time and changed to few of them clicking 'change link' #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

TD-5290- Issue on 'Course set up' screen when selected All course content first time and changed to few of them clicking 'change link' #3098

wants to merge 2 commits into from

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Jan 31, 2025 •
edited by atlassian bot
Loading

JIRA link

TD-5290

Description

SectionContentData is updated in edit mode according to existing and newly selected sections.

Screenshots

N/A

Developer checks

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review January 31, 2025 10:17
rshrirohit
rshrirohit requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@rshrirohit rshrirohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Auldrin-Possa can we look at the merge conflicts and resolve them, please?

@Auldrin-Possa
Copy link
Collaborator Author

Auldrin-Possa commented Feb 24, 2025

@Auldrin-Possa can we look at the merge conflicts and resolve them, please?

@rshrirohit- PR TD-5290 covered issues of TD-5291 and TD-5292 too. As per our discussion, we preferred to merge PR TD-5291 as it was raised before TD-5290 and decided to close PR TD-5290 if PR TD-5291 covers issues of TD-5290.

@rshrirohit rshrirohit closed this Feb 25, 2025
@rshrirohit rshrirohit deleted the Develop/Fix/TD-5290-CourseSetUp-change-link-Issue branch February 25, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rshrirohit rshrirohit rshrirohit requested changes

@kevwhitt-hee kevwhitt-hee Awaiting requested review from kevwhitt-hee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Auldrin-Possa @rshrirohit